[Bug][SQL] Fix bug that query failed when SQL contains Union and Colocate join#4842
Merged
morningman merged 2 commits intoapache:masterfrom Nov 5, 2020
Merged
[Bug][SQL] Fix bug that query failed when SQL contains Union and Colocate join#4842morningman merged 2 commits intoapache:masterfrom
morningman merged 2 commits intoapache:masterfrom
Conversation
…cate Join. SQL like: `select a join b union select c join d`; if a b is colocate join, and c d is also colocate join, the query may failed with error like: `failed to get tablet. tablet_id=26846, with schema_hash=398972982, reason=tablet does not exist`
morningman
added
kind/fix
HappenLee
reviewed
Nov 4, 2020
| @@ -1140,17 +1141,26 @@ private long getScanRangeLength(final TScanRange scanRange) { | |||
|
|
|||
| private void computeColocateJoinInstanceParam(PlanFragmentId fragmentId, int parallelExecInstanceNum, FragmentExecParams params) { | |||
| Map<Integer, TNetworkAddress> bucketSeqToAddress = fragmentIdToSeqToAddressMap.get(fragmentId); | |||
Contributor
There was a problem hiding this comment.
Maybe bucketSeqToScanRang should be a map like fragmentIdToSeqToAddressMap to solve this problem is a
better understanding way？
Contributor
Author
There was a problem hiding this comment.
I will leave it when refactoring them.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
SQL like:
select a join b union select c join d;if both a/b and c/d are colocate join, the query may failed with error like:
failed to get tablet. tablet_id=26846, with schema_hash=398972982, reason=tablet does not existThis is because when assigning exec host for fragment, the planner failed to distinguish which scan nodes
belong to the certain fragment. So it may choose the wrong host for scan range.
Types of changes
Checklist